Add set_span_finish_callback macro to telemetry::tracing #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJokr
force-pushed
the
lblocher/rustracing-callback
branch
from
500146d to
c344311
Compare
cbranch
approved these changes
Sep 30, 2025
TheJokr
force-pushed
the
lblocher/rustracing-callback
branch
from
c344311 to
e53a5d7
Compare
The macro simplifies access to the new `Span::set_finish_callback` interface I added to rustracing. It allows users to set a callback on the active span and to remove it again.
TheJokr
force-pushed
the
lblocher/rustracing-callback
branch
from
e53a5d7 to
2ef614e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro simplifies access to the new
Span::set_finish_callbackinterface I added to rustracing. It allows users to set a callback on the active span and to remove it again.Depends on cloudflare/rustracing#6