Add a new SharedSpanHandle::Inactive variant #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
force-pushed
the
ivan/empty-stack
branch
from
5f643a0 to
ac9b53a
Compare
TheJokr
requested changes
Sep 30, 2025
It's expected that most of the spans are not sampled. We still clone and stack them, which adds up. Let's add a new variant for unsampled spans that is cheaper to clone.
bobrik
force-pushed
the
ivan/empty-stack
branch
from
ac9b53a to
83cf926
Compare
bobrik
changed the title
TheJokr
approved these changes
Oct 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expected that most of the spans are not sampled. We still clone and stack them, which adds up. Let's add a new variant for unsampled spans that is cheaper to clone.