Remove doc_auto_cfg to clear errors on nightly #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bobrik
commented
Sep 30, 2025
bobrik
commented
``` error[E0557]: feature has been removed --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/socket2-0.6.0/src/lib.rs:57:29 | 57 | #![cfg_attr(docsrs, feature(doc_auto_cfg))] | ^^^^^^^^^^^^ feature has been removed | = note: removed in CURRENT_RUSTC_VERSION; see <rust-lang/rust#138907> for more information = note: merged into `doc_cfg` ```
bobrik
force-pushed
the
ivan/no-doc-auto-cfg
branch
from
3db5786 to
d330a15
Compare
bobrik
changed the title
bobrik
force-pushed
the
ivan/no-doc-auto-cfg
branch
from
d330a15 to
7ff4d70
Compare
TheJokr
approved these changes
Sep 30, 2025
Collaborator
|
ugh, looks like we need to change the name of our docsrs flag (or socket2 needs to be fixed). can you replace E: did this myself since it also blocks my PR |
By using a crate-specific `cfg(foundations_docsrs)` we avoid enabling the removed feature in our dependency crates.
fisherdarling
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.