Add #[with_removal] attribute to #[metrics] macro #156
+323
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJokr
force-pushed
the
lblocher/expose-raw-family
branch
from
08f285f to
5b53bd4
Compare
This helps document the `cfg` values foundations understands.
`#[with_removal]` generates two additional functions that allow to remove individual label sets from a metric family as well as clear the family completely. This is useful when metrics are used for dynamic data, such as peer RTT in a P2P system. The feature is hidden behind `cfg(foundations_unstable)`, which allows us to iterate on the API in the future. Both proc-macro unit tests as well as an integration test are included in the change.
TheJokr
force-pushed
the
lblocher/expose-raw-family
branch
from
5b53bd4 to
c05704b
Compare
fisherdarling
approved these changes
Dec 1, 2025
Collaborator
fisherdarling
left a comment
fisherdarling
left a comment
There was a problem hiding this comment.
Looks good!
General q, is it possible to have an API of:
regular::dynamic("foo").remove();
Rather than having the _remove suffix?
Collaborator
Author
Yes, good idea! I'll make some changes to the PR. E: Discussed a bit more, it's quite unergonomic to implement such an API because my prometools change wasn't designed for it. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[with_removal]generates two additional functions that allow toremove individual label sets from a metric family as well as clear the
family completely. This is useful when metrics are used for dynamic
data, such as peer RTT in a P2P system.
The feature is hidden behind
cfg(foundations_unstable), which allowsus to iterate on the API in the future. Both proc-macro unit tests as
well as an integration test are included in the change.
Tests on this PR will fail until nox/prometools#6 is merged and released, which
exposes the necessary
FamilyAPIs to implement this feature.