Remove unmatched path label from request histogram #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freighter generates a histogram with lots of buckets for each individual URL path that 404s. This quickly blows past any reasonable scrape limit if a Freighter instance gets hit by web scrapers. To fix this, record the `path` label only for route matches. An empty string is equivalent to no label in Prometheus' data model.
kornelski
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freighter generates a histogram with lots of buckets for each individual
URL path that 404s. This quickly blows past any reasonable scrape limit
if a Freighter instance gets hit by web scrapers. To fix this, record
the
pathlabel only for route matches. An empty string is equivalentto no label in Prometheus' data model.
I also included a version bump to get this fix out quickly.