fix: validate BytesValue length in KeyValuePair encoding #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cloudflare#128 Per draft-ietf-moq-transport-15 section 1.4.2, the maximum length of a BytesValue is 2^16-1 bytes. Previously, the code would accept BytesValues exceeding this limit during encoding, which could cause protocol violations when the peer attempts to decode the message. Now checks if the BytesValue length exceeds u16::MAX before encoding and returns EncodeError::InvalidValue if the limit is exceeded, matching the existing validation in the decode path.
diegocatalao
force-pushed
the
fix/validate-bytes-value-into-kvp-encoding
branch
from
ad89227 to
6d36e45
Compare
|
A question which is out of scope, is Cloudflare's implementation compatible with WARP/MSF draft-1? |
Author
sorry, i don't know. maybe @englishm can answer you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per draft-ietf-moq-transport-15 section 1.4.2, the maximum length of a BytesValue is 2^16-1 bytes. Previously, the code would accept BytesValues exceeding this limit during encoding, which could cause protocol violations when the peer attempts to decode the message. Now checks if the BytesValue length exceeds u16::MAX before encoding and returns EncodeError::InvalidValue if the limit is exceeded, matching the existing validation in the decode path.