_Really_ don't inline dynamic imports #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30d692a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -108,6 +108,10 @@ export async function getSuspenseCacheAdaptor(): Promise<CacheAdaptor> { | |||
| return getInternalCacheAdaptor('cache-api'); | |||
| } | |||
|
|
|||
| async function doImport(m: string) { | |||
There was a problem hiding this comment.
I'd add a comment clarifying what this function is for
Comment on lines
35
to
37
| async function doImport(m: string) { | ||
| return import(m); | ||
| } |
There was a problem hiding this comment.
I'd probably have a single doImport function (maybe in its own file under utils/) so that we can also add comments to it without repetition, etc..
dario-piotrowicz
approved these changes
Feb 27, 2025
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/13574133319/npm-package-next-on-pages-946@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/13574133319/npm-package-eslint-plugin-next-on-pages-946 |
dario-piotrowicz
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 of #940, which was still inlining dynamic imports due to esbuild's minification algorithm removing the intermediate variables.