Route root docs index through catch-all - #111
Closed
sansynx wants to merge 1 commit into
Closed
Conversation
This was referenced Sep 4, 2026
Collaborator
|
This has been resolved on main as part of the broader server-side rendering and API-reference work in #114. Closing as superseded, along with the linked issue. |
Contributor
Author
|
Makes sense, thanks for the heads up. I'll leave this closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDocsStaticPathsreturned the root docs entry asslug: "index", while the rest of Nimbus treats that entry as/. The main site carried a local mapping, but the starter used the helper directly.This normalizes the root entry in the shared helper, removes the duplicate main-site workaround, and adds a route contract test.
Closes #102
Checks
node --import tsx --test test/docs-root-route-contract.test.tspnpm --filter nimbus-docs typecheckpnpm --filter nimbus-docs buildpnpm --filter nimbus-starter-source build