Skip to content

feat: use native Sätteri admonitions and remove unsupported MDX plugi… - #131

Closed
MohamedH1998 wants to merge 8 commits into
mainfrom
feat/native-satteri-admonitions
Closed

feat: use native Sätteri admonitions and remove unsupported MDX plugi…#131
MohamedH1998 wants to merge 8 commits into
mainfrom
feat/native-satteri-admonitions

Conversation

@MohamedH1998

@MohamedH1998 MohamedH1998 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

What & why

Nimbus’s source-level admonition transform could corrupt valid MDX
containing nested directives, fenced code, or surrounding
components. This replaces it with Sätteri’s native directive
processing and maps admonitions onto the existing Aside contract
without changing the component or its plain title prop.

The change also fixes link normalization around fenced code in
HTML and MDX components, exposes the native Sätteri and Astro MDX
extension points, updates the authoring guidance, and removes
unused parser dependencies.

Validated with focused transformation and rendering tests, the
Workers feasibility check, and the Cloudflare and Node template
lanes.

Checklist

  • Maintainer approval or team membership
  • Changes placed in the appropriate framework and starter tiers
  • Starter source edited; templates generated
  • Changeset covers both affected packages
  • Full pnpm typecheck, pnpm -r test, and pnpm templates:check
    verified

@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 10, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 10, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026

Copy link
Copy Markdown
pnpm add https://pkg.pr.new/@cloudflare/create-nimbus-docs@131
pnpm add https://pkg.pr.new/@cloudflare/nimbus-docs@131

commit: fd66913

@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 10, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 10, 2026
@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 10, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 10, 2026
@MohamedH1998
MohamedH1998 marked this pull request as ready for review September 10, 2026 19:28
@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 11, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 11, 2026
@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 12, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 12, 2026
@MohamedH1998
MohamedH1998 marked this pull request as draft September 12, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant