feat: allow regex patterns in promql/aggregate keep and strip parameters #1690
+621
−123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements issue #509, allowing users to specify regex patterns in the
keepandstripparameters for thepromql/aggregatecheck.Changes
AggregationCheckto accept a regex pattern for label matching instead of requiring literal stringsextractLiteralLabelshelper to extract individual labels from simple alternation patterns likejob|instancesrc.Labelsthat match the pattern are checkedExample Usage
Fixes #509