Fix context leak in rule/link check loop #1691
Open
+63
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
defer cancel()inside a for loopcheckLink()method where defer properly releases resourcesBug Description
In
RuleLinkCheck.Check(), a context with timeout was created inside a for loop for each annotation being checked:When checking multiple link annotations, the
cancelfunctions would stack up and only be called whenCheck()returns, not at the end of each loop iteration. This causes:Fix
Extract the HTTP request logic into a separate
checkLink()method. Thedefer cancel()in this new method correctly releases resources when each individual link check completes.Testing
All existing tests pass: