-
Notifications
You must be signed in to change notification settings - Fork 5
Merge upstream and keep cloudflare bits under its own folder to avoid future conflicts #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old documents
- Adds integrity hashes that were missing for 5 npm packages in `package-lock.json` <hr /> Is there a reason hashes for some of these dependencies are missing from `package-lock.json`? Right now these omissions prevent me from packaging a nix derivation for this mcp server directly off this repo (https://github.com/cameronfyfe/nix-mcp-servers/blob/main/pkgs/servers/mcp-server-playwright/default.nix#L17) and I was wondering if they might just be missing due to a bad merge or something odd like that at some point. `npm install` under normal use doesn't seem to care if the hashes are missing and installs the packages anyway, but it's a blocker for hermetic build systems like nix. If this is intentional for some reason I'm not familiar with feel free to ignore and close.
Motivation: Keeping the readme up to date is a manual effort - this keeps it automatically up to date and prevents things like microsoft/playwright-mcp#214 and other consistency errors in the future.
Moves the `schema.parse` call to the calling side of the handler, so we don't have to duplicate it everywhere.
dc34fe2
to
3131053
Compare
https://playground.ai.cloudflare.com passes "null" as values in element and ref for browser_take_screenshot
3131053
to
dd2cc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
and new release of
@cloudflare/playwright