Add rustls compile time support #2045
Open
+3,907
−2,305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add base structs and methods/functions required to compile rustls feature
rustls does not support v1 (needs v3) certificates
|
Hi @hargut thank you for the PR and nice job. Can you help me understand if there is something that rustls provides that you can't get from boringSSL (our default TLS provider)? Another TLS backend means more code that we need to test and maintain and adds to the complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rustls compile time support to quiche. #1259
The implementation intended to change as little as possible within the existing quiche library. As rustls is in some ways different to the already integrated TLS providers some changes had been necessary.
Additionally it was intended to stick to the existing configuration defaults which required to use some
dangerareas of rustls (related to changing the certificate validation defaults).Any feedback is highly appreciated.
Have a great time. 😃