Skip to content

Delete standalone binaries#443

Merged
ghostwriternr merged 2 commits intomainfrom
fix/offload-large-binaries
Mar 6, 2026
Merged

Delete standalone binaries#443
ghostwriternr merged 2 commits intomainfrom
fix/offload-large-binaries

Conversation

@scuffi
Copy link
Copy Markdown
Contributor

@scuffi scuffi commented Mar 3, 2026

Summary

Removes the two large binaries stored in this repo & adds them to .gitignore so we don't have this issue again

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 275306f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode Review

Good solution for reducing clone size. The .gitattributes configuration is correct and the changeset follows project conventions.

One fix needed: The README instruction order is wrong. git lfs install must run before git clone when cloning an LFS repo, not after.

Looks good to merge after fixing the README.

github-actions[bot]

This comment was marked as outdated.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 3, 2026

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@443

commit: 2cb7c62

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

🐳 Docker Images Published

Default:

FROM cloudflare/sandbox:0.0.0-pr-443-dc2d84e

With Python:

FROM cloudflare/sandbox:0.0.0-pr-443-dc2d84e-python

With OpenCode:

FROM cloudflare/sandbox:0.0.0-pr-443-dc2d84e-opencode

Version: 0.0.0-pr-443-dc2d84e

Use the -python variant if you need Python code execution, or -opencode for the variant with OpenCode AI coding agent pre-installed.


📦 Standalone Binary

For arbitrary Dockerfiles:

COPY --from=cloudflare/sandbox:0.0.0-pr-443-dc2d84e /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]

Download via GitHub CLI:

gh run download 22620657820 -n sandbox-binary

Extract from Docker:

docker run --rm cloudflare/sandbox:0.0.0-pr-443-dc2d84e cat /container-server/sandbox > sandbox && chmod +x sandbox

@whoiskatrin
Copy link
Copy Markdown
Collaborator

/bonk review this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 3, 2026

Downloading sandbox-linux-x64 (104 MB)
Error downloading object: sandbox-linux-x64 (763f8eb): Smudge error: Error downloading sandbox-linux-x64 (763f8eba666d3a68e09a8151c0f5b40a01a9d52d3e288a2f788a733ea8ab5cd0): batch response: Git LFS is disabled for this repository.

Errors logged to '/home/runner/work/sandbox-sdk/sandbox-sdk/.git/lfs/logs/20260303T234857.049156321.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: sandbox-linux-x64: smudge filter lfs failed

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 3, 2026

@whoiskatrin Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Copy link
Copy Markdown
Member

@ghostwriternr ghostwriternr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is - these files shouldn't even be checked into our source code, so I don't see the point of even moving them to LFS. They got introduced by accident and we never noticed. I'd recommend just deleting these files + modifying the .gitignore to include sandbox-linux-*.

What this means is that these files will still remain in our git history, so vanilla git clone would still pull the whole thing as part of the history, regardless of what we do — unless we use something like git-filter-repo but that will rewrite our commit history ever since these blobs were introduced... exactly 2 months ago.

@scuffi scuffi force-pushed the fix/offload-large-binaries branch from 2cb7c62 to a67b643 Compare March 6, 2026 15:36
Copy link
Copy Markdown
Member

@ghostwriternr ghostwriternr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update PR desc and remove the changeset (this change doesn't affect releases)

@scuffi scuffi changed the title Move standalone binaries to Git LFS Delete standalone binaries Mar 6, 2026
@ghostwriternr ghostwriternr merged commit cdea095 into main Mar 6, 2026
14 checks passed
@ghostwriternr ghostwriternr deleted the fix/offload-large-binaries branch March 6, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants