Conversation
|
There was a problem hiding this comment.
OpenCode Review
Good solution for reducing clone size. The .gitattributes configuration is correct and the changeset follows project conventions.
One fix needed: The README instruction order is wrong. git lfs install must run before git clone when cloning an LFS repo, not after.
Looks good to merge after fixing the README.
commit: |
🐳 Docker Images PublishedDefault: FROM cloudflare/sandbox:0.0.0-pr-443-dc2d84eWith Python: FROM cloudflare/sandbox:0.0.0-pr-443-dc2d84e-pythonWith OpenCode: FROM cloudflare/sandbox:0.0.0-pr-443-dc2d84e-opencodeVersion: Use the 📦 Standalone BinaryFor arbitrary Dockerfiles: COPY --from=cloudflare/sandbox:0.0.0-pr-443-dc2d84e /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]Download via GitHub CLI: gh run download 22620657820 -n sandbox-binaryExtract from Docker: docker run --rm cloudflare/sandbox:0.0.0-pr-443-dc2d84e cat /container-server/sandbox > sandbox && chmod +x sandbox |
|
/bonk review this PR |
|
Downloading sandbox-linux-x64 (104 MB) Errors logged to '/home/runner/work/sandbox-sdk/sandbox-sdk/.git/lfs/logs/20260303T234857.049156321.log'. |
|
@whoiskatrin Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
There was a problem hiding this comment.
The thing is - these files shouldn't even be checked into our source code, so I don't see the point of even moving them to LFS. They got introduced by accident and we never noticed. I'd recommend just deleting these files + modifying the .gitignore to include sandbox-linux-*.
What this means is that these files will still remain in our git history, so vanilla git clone would still pull the whole thing as part of the history, regardless of what we do — unless we use something like git-filter-repo but that will rewrite our commit history ever since these blobs were introduced... exactly 2 months ago.
2cb7c62 to
a67b643
Compare
ghostwriternr
left a comment
There was a problem hiding this comment.
nit: update PR desc and remove the changeset (this change doesn't affect releases)
Summary
Removes the two large binaries stored in this repo & adds them to
.gitignoreso we don't have this issue again