Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Conversation

@AntoineAugusti
Copy link
Contributor

I'm opening this PR even if it's not finished yet as I'd love some feedback. My goal is to write some integration tests for the service and controller components mainly.

This PR could also be a great opportunity to set up some kind of continuous integration, to fight against regressions.

My questions:

  • which remaining tests would be useful to write?
  • should I put tests in a different package?
  • should I separate tests in different files, as I am testing service + controller here?
  • should I improve some parts of my code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly done for testing purposes

@AntoineAugusti
Copy link
Contributor Author

Ping @BURO9

@AntoineAugusti AntoineAugusti force-pushed the integration-tests-service-controller branch from b66b1ed to bd93717 Compare December 18, 2015 17:01
@AntoineAugusti
Copy link
Contributor Author

Any comments @BURO9?

@AntoineAugusti
Copy link
Contributor Author

Bump ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant