Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 44 - Pause tests when the page is not visible to stop leaking timers #46

Conversation

yomnaebrahim
Copy link
Contributor

To Fix Issue 44: #44

Adding an event listener to determine if the page of the test is visible or not and pause/play the test accordingly.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Please set a semver versioning label of either major, minor, or patch on this pull request.

@yomnaebrahim yomnaebrahim changed the title Issue-44 - Pause tests when the page is not focus Fix Issue 44 - Pause tests when the page is not visible to stop leaking timers Jan 2, 2025
@matthieugouel matthieugouel self-assigned this Jan 2, 2025
@yomnaebrahim yomnaebrahim merged commit 3bdc704 into main Jan 2, 2025
7 of 8 checks passed
@matthieugouel matthieugouel deleted the issue-44-test-requests-do-not-stop-when-tab-is-not-visible branch January 3, 2025 21:31
Copy link

@yacine-bens yacine-bens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOM is not available in service workers, could you add a condition for document calls please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants