Cancel stateless tasks before request teardown to correctly close their spans - #7137
Open
apeacock1991 wants to merge 2 commits into
Open
Cancel stateless tasks before request teardown to correctly close their spans#7137apeacock1991 wants to merge 2 commits into
apeacock1991 wants to merge 2 commits into
Conversation
apeacock1991
force-pushed
the
apeacock/fix-request-teardown-order
branch
from
August 27, 2026 10:25
0a6bc2f to
063e463
Compare
Contributor
|
@apeacock1991 Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
apeacock1991
force-pushed
the
apeacock/fix-request-teardown-order
branch
from
August 27, 2026 11:06
063e463 to
a53692e
Compare
Contributor
|
LGTM |
danlapid
reviewed
Aug 30, 2026
danlapid
reviewed
Aug 30, 2026
apeacock1991
force-pushed
the
apeacock/fix-request-teardown-order
branch
13 times, most recently
from
September 3, 2026 12:56
1ed7fd3 to
92f6a25
Compare
danlapid
reviewed
Sep 3, 2026
apeacock1991
force-pushed
the
apeacock/fix-request-teardown-order
branch
2 times, most recently
from
September 3, 2026 13:59
08b5779 to
34a8d61
Compare
danlapid
reviewed
Sep 3, 2026
An IncomingRequest holding the final IoContext reference can still have context tasks, wait-until tasks, and reentry callbacks with open spans. Cancel them while the request is current so the spans close before its outcome is reported. If cleanup throws, continue canceling the remaining callbacks and tasks, then rethrow the first exception after request teardown. Keep actor task and timeout cleanup on their existing paths.
apeacock1991
force-pushed
the
apeacock/fix-request-teardown-order
branch
from
September 3, 2026 17:15
34a8d61 to
53b4384
Compare
danlapid
approved these changes
Sep 4, 2026
danlapid
left a comment
danlapid
left a comment
Collaborator
There was a problem hiding this comment.
Let's put this behind an autogate and merge
Keep final-owner cancellation disabled unless the existing JSRPC tracing autogate is enabled. Leave shared-context abort cleanup unchanged.\n\nExercise legacy teardown ordering in the default test variant and early cleanup in the all-autogates variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stateless context tasks can own trace spans that need the current IncomingRequest while they close. Cancel those tasks before recording the request outcome and removing the request.
Preserve abort reasons and undrained-task diagnostics while matching IoContext's task and timer destruction order.