Skip to content

Fix memory-cache/lib.rs to use try_update instead of fetch_update. #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dom96 merged 1 commit into from
Sep 3, 2026
+2 −8
Merged

Fix memory-cache/lib.rs to use try_update instead of fetch_update. #7211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/per_isolate/primordials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,7 @@ const DataViewPrototypeGetByteLength = getProtoGetter<
// lookups can't be confused via Object.prototype pollution. DataView is not
// in this map (the getter returns undefined for it) — detect it separately
// and use the DataView capture above.
// Float16Array is enabled unconditionally via --js-float16array (jsg
// setup.c++), so a plain capture is safe.
// Float16Array is enabled unconditionally, so a plain capture is safe.
const TypedArrayCtorByName = ObjectFreeze(
ObjectSetPrototypeOf(
{
Expand Down
2 changes: 1 addition & 1 deletion src/rust/memory-cache/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ fn elapsed_ns(start: Instant) -> u64 {

fn saturating_increment(counter: &AtomicUsize) -> usize {
counter
.fetch_update(AtomicOrdering::Relaxed, AtomicOrdering::Relaxed, |value| {
.try_update(AtomicOrdering::Relaxed, AtomicOrdering::Relaxed, |value| {
Some(value.saturating_add(1))
})
.unwrap_or(usize::MAX)
Expand Down
5 changes: 0 additions & 5 deletions src/workerd/jsg/setup.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,6 @@ void V8System::init(kj::Own<v8::Platform> platformParam,
// more flags.)
v8::V8::SetFlagsFromString("--noincremental-marking");

// These features are completed and enabled by default in Chrome, but not
// in V8. Follows Node.js: https://github.com/nodejs/node/pull/58154
v8::V8::SetFlagsFromString("--js-explicit-resource-management");
v8::V8::SetFlagsFromString("--js-float16array");

// Enable source phase imports for WebAssembly modules
v8::V8::SetFlagsFromString("--js-source-phase-imports");

Expand Down
Loading