Fix internal build for forks of org members - #7243
Open
ketanhwr wants to merge 1 commit into
Open
Conversation
Contributor
|
|
Contributor
|
I'm Bonk, and I've done a quick review of your PR. PR #7243 enables trusted fork checkout for the internal build workflow.
|
ketanhwr
force-pushed
the
ketan/fix-internal-build-fork
branch
from
September 4, 2026 09:02
e43bfc0 to
d1de5bc
Compare
ketanhwr
force-pushed
the
ketan/fix-internal-build-fork
branch
from
September 4, 2026 09:07
d1de5bc to
34c9b79
Compare
Contributor
|
LGTM |
dom96
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal build stopped working a few weeks ago when Github changed their defaults for running
pull_request_targetworkflows on forks: https://github.blog/changelog/2026-06-18-safer-pull_request_target-defaults-for-github-actions-checkout/In our case, we only checkout the code after we've verified that the fork belongs to an org member, so it should be safe.