-
Notifications
You must be signed in to change notification settings - Fork 429
Regenerate email bindings with per-mono generics #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: flagship-per-mono-generics
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,7 +44,7 @@ async fn email(message: ForwardableEmailMessage, _env: Env, _ctx: Context) -> Re | |
| .write_to_string() | ||
| .map_err(|e| Error::RustError(e.to_string()))?; | ||
|
|
||
| let reply = email::EmailMessage::new(&to, &from, &raw)?; | ||
| let reply = email::EmailMessage::new(to, from, raw)?; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is required because |
||
| message.reply(&reply).await?; | ||
| Ok(()) | ||
| } | ||
|
|
||
| +11 −0 | CONVENTIONS.md | |
| +5 −2 | integration-tests/tests/generic_mono.rs | |
| +12 −6 | src/codegen/classes.rs | |
| +21 −6 | src/codegen/signatures.rs | |
| +4 −0 | tests/fixtures/generic-mono.d.ts | |
| +20 −0 | tests/snapshots/generic-mono.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worker-sys/src/types/email.rsisn't wired intoworker-sysat all (nomod email;inworker-sys/src/types.rs) — it's an orphan from #996. Delete the file instead of adding this second invocation.