Make Storage::get return an option
#859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI fix in #860, which I'll land now, then this can be based to that. |
rozbb
changed the title
Storage::get_maybe. Deprecate Storage::getStorage::get specify when the return value is not defined
rozbb
changed the title
Storage::get specify when the return value is not definedStorage::get specify when the requested key doesn't exist
guybedford
changed the title
Storage::get specify when the requested key doesn't existStorage::get return an option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams the fix in cloudflare/azul#148 . The issue in that code base was that an error value from
Storage::getwas interpreted as a missing key regardless of what the error was. This turned out to be a huge footgun.This PR changes the type signature to
get(key: &str) -> Result<Option<T>>, returningOk(None)when the key is not defined. This lets the caller distinguish between missing keys and proper errors.