Support --panic-unwind worker-build option #912
Merged
+451
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
panic-unwind
branch
from
d1dd568 to
3dd5bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
panic=unwindnow supported in Wasm Bindgen 0.2.108, this adds a newworker-build --panic-unwindflag which when set will allow fully recoverable panics where possible.This also integrates with the reinitialization support to treat panic errors as recoverable and non-critical.
This work requires the upstream fixes to the wasm-streams library in MattiasBuelens/wasm-streams#28, which are added here as a submodule for now.
Then after careful testing further,
--panic-unwindshould become our default build strategy going forward.