refactor(wrangler): add safe command/args handling for telemetry #12063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a78386 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
commented
Jan 23, 2026
| // (used when yargs validation errors occur before handler runs) | ||
| command = `wrangler ${args._.join(" ")}`; | ||
| metricsArgs = args; | ||
| safeCommand = args._.join(" "); |
Contributor
Author
There was a problem hiding this comment.
@MattieTK - do we want this just to be "" since we cannot guarantee that the args don't contain something sensitive?
petebacondarwin
force-pushed
the
pbd/clean-command-metrics
branch
from
3fd5325 to
7e9344a
Compare
petebacondarwin
force-pushed
the
pbd/safe-command-args-metrics
branch
2 times, most recently
from
bd603d8 to
2e40a31
Compare
petebacondarwin
changed the base branch from
pbd/clean-command-metrics
to
pbd/wrangler/migrate-containers-to-define-command
petebacondarwin
force-pushed
the
pbd/wrangler/migrate-containers-to-define-command
branch
from
a073093 to
db843d1
Compare
petebacondarwin
force-pushed
the
pbd/safe-command-args-metrics
branch
from
2e40a31 to
3ad4dd8
Compare
- Rename 'command' to 'safeCommand' (without 'wrangler ' prefix) and 'args' to 'safeArgs' in telemetry events - Add 'logArgs' boolean to control whether command arguments are included in telemetry - Commands must explicitly opt-in via metadata.logArgs: true to log arguments - Safe commands (list, info, get, etc.) that don't handle sensitive data opt-in to logging - Sensitive commands (secret put/delete/bulk, hyperdrive create) intentionally do not opt-in - Update fallback telemetry in index.ts to use new format with logArgs: false
petebacondarwin
force-pushed
the
pbd/safe-command-args-metrics
branch
from
3ad4dd8 to
5a78386
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves telemetry safety by introducing explicit control over which command arguments are included in telemetry events, preventing accidental capture of sensitive data like secrets and credentials.
Replaces #11856
Builds on top of #12069 and Builds on top of #12071
Renamed telemetry fields for clarity:
Added logArgs control:
Opted-in safe commands (~100 commands) that don't handle sensitive input:
Intentionally excluded sensitive commands:
Tests
Public documentation
A picture of a cute animal (not mandatory, but encouraged)