Skip to content

Add support for applications that use the entry Worker during development but not at build time#12788

Merged
penalosa merged 10 commits into
mainfrom
james/inferred-assets-only
May 5, 2026
Merged

Add support for applications that use the entry Worker during development but not at build time#12788
penalosa merged 10 commits into
mainfrom
james/inferred-assets-only

Conversation

@jamesopstad

Copy link
Copy Markdown
Contributor

Add support for applications that use the entry Worker during development but not at build time

Some frameworks, such as Astro, use the ssr environment during development but omit it from the build if the app is fully static. In these cases, we now output an assets only version of the user's input Wrangler config to the output config in the client output directory.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: framework specific

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Mar 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 147d12d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

Reviewed: .changeset/rare-ducks-occur.md

Criterion Status
Version Type ✅ Minor is appropriate for new feature/support
Changelog Quality ✅ Clear description with context and use case
Markdown Headers ✅ No h1/h2/h3 headers
Analytics ✅ N/A - no analytics changes
Dependabot ✅ N/A - not a dependency update
Experimental Features ✅ N/A - not an experimental feature

@jamesopstad jamesopstad force-pushed the james/inferred-assets-only branch from e991aa8 to 8c9d3b7 Compare March 6, 2026 14:56
@pkg-pr-new

pkg-pr-new Bot commented Mar 6, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12788

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12788

miniflare

npm i https://pkg.pr.new/miniflare@12788

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12788

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12788

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12788

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12788

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12788

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12788

wrangler

npm i https://pkg.pr.new/wrangler@12788

commit: 147d12d

@petebacondarwin

Copy link
Copy Markdown
Contributor

Hi @jamesopstad — we're doing some cleanup of stale draft PRs.

This PR has been quiet since 2026-04-23. Could you let us know within 14 days whether you're still planning to continue?

  • If yes: please leave a comment with a status update or push a rebase, and we'll keep it open.
  • If no: no need to reply — we'll close it after 14 days, and you can always reopen later if you pick it back up.

Thanks!

@jamesopstad

Copy link
Copy Markdown
Contributor Author

Hi @jamesopstad — we're doing some cleanup of stale draft PRs.

This PR has been quiet since 2026-04-23. Could you let us know within 14 days whether you're still planning to continue?

  • If yes: please leave a comment with a status update or push a rebase, and we'll keep it open.
  • If no: no need to reply — we'll close it after 14 days, and you can always reopen later if you pick it back up.

Thanks!

This needs to stay open as it's being tested by the Astro team.

@jamesopstad jamesopstad force-pushed the james/inferred-assets-only branch 3 times, most recently from ab2b9da to 45dc232 Compare April 29, 2026 14:34
@jamesopstad

Copy link
Copy Markdown
Contributor Author

This has been tested and given the go ahead by the Astro team now.

@jamesopstad jamesopstad marked this pull request as ready for review April 29, 2026 14:50
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team April 29, 2026 14:50
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/vite-plugin-cloudflare/playground/test-utils/index.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/test-utils/vite-version.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/multi-worker/tests/custom-build-app/multi-worker.spec.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/prerendering/tests/base-tests.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/prerendering/tests/no-ssr/prerendering.spec.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/prerendering/tests/prerendering.spec.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/prerendering/index.html: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/prerendering/vite.config.no-ssr.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/prerendering/vite.config.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/deploy-config.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/plugins/config.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/plugins/output-config.ts: [@cloudflare/wrangler]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

@ematipico

Copy link
Copy Markdown

Any updates @jamesopstad ?

@jamesopstad jamesopstad force-pushed the james/inferred-assets-only branch from 45dc232 to 147d12d Compare May 5, 2026 09:32
@workers-devprod

workers-devprod commented May 5, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@penalosa penalosa merged commit 31a71c6 into main May 5, 2026
56 checks passed
@penalosa penalosa deleted the james/inferred-assets-only branch May 5, 2026 12:08
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 5, 2026
@penalosa penalosa added the run-c3-frameworks-tests Run all the C3 frameworks tests on this PR label May 5, 2026
@penalosa penalosa removed the run-c3-frameworks-tests Run all the C3 frameworks tests on this PR label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants