You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
I see. The makeFetch function uses the remoteProxyConnectionString directly (line 50) and puts MF-Binding in the headers, not the URL search params. Meanwhile makeRemoteProxyStub adds MF-Binding to the URL search params (line 65). The isJSRPCBinding check on the server only looks at URL search params, so the "raw" fetch path (which puts MF-Binding only in headers) will correctly NOT match isJSRPCBinding. The routing logic is sound.
Now let me verify there's no case where a raw fetch path could accidentally have MF-Binding in the query string. The makeFetch function on line 50 does fetch(remoteProxyConnectionString, req) — it uses the connection string directly as the URL without modifying search params. So the routing change is safe.
The changes look correct and straightforward:
Switch from WebSocket-based RPC to HTTP batch-based RPC (newWebSocketRpcSession → newHttpBatchRpcSession)
Remove the protocol conversion to wss:/ws: since HTTP batch doesn't need WebSocket
Simplify isJSRPCBinding to not require the Upgrade header check since HTTP batch doesn't use WebSocket upgrades
Update the comment to reflect both transport options
The @ts-expect-error is a minor concern but it's already cast to unknown right after, making it a pragmatic workaround for the deep type instantiation issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #[insert GH or internal issue link(s)].
Describe your change...
A picture of a cute animal (not mandatory, but encouraged)