Skip to content

[Stream] Add Stream binding local mode#13030

Open
natewong1313 wants to merge 1 commit intomainfrom
nwong/STREAM-6694
Open

[Stream] Add Stream binding local mode#13030
natewong1313 wants to merge 1 commit intomainfrom
nwong/STREAM-6694

Conversation

@natewong1313
Copy link
Member

@natewong1313 natewong1313 commented Mar 23, 2026

This MR adds local mode support for the Stream binding. Its architected as follows

  • entry worker in binding.worker.ts has a bunch of RPC targets, which mimics our production implementation
  • DO in object.worker.ts handles blob storage for video/watermark files, plus SQLlite for crud operations

Note that this MR doesn't support creating direct upload URLs yet but I'll do that in a follow up MR


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Feature is in progress

A picture of a cute animal (not mandatory, but encouraged)
image


Open with Devin

@natewong1313 natewong1313 requested a review from a team as a code owner March 23, 2026 23:29
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

🦋 Changeset detected

Latest commit: 83d3150

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/index.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/plugins/index.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/plugins/stream/index.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/workers/shared/index.worker.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/workers/stream/binding.worker.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/workers/stream/errors.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/workers/stream/object.worker.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/workers/stream/schemas.ts: [@cloudflare/wrangler]
  • packages/miniflare/test/plugins/stream/index.spec.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/dev/miniflare/index.ts: [@cloudflare/wrangler]

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 23, 2026

APIError: Not Found: Not found

github run

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 23, 2026

@natewong1313 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@natewong1313 natewong1313 changed the title feat: Add Stream binding local mode [Stream] Add Stream binding local mode Mar 23, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 23, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13030

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13030

miniflare

npm i https://pkg.pr.new/miniflare@13030

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13030

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13030

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13030

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13030

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13030

wrangler

npm i https://pkg.pr.new/wrangler@13030

commit: 83d3150

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants