Support V2 protocol for module fallback service in Miniflare and Vite plugin#13618
Merged
Conversation
🦋 Changeset detectedLatest commit: 64db9aa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@jamesopstad Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
jamesopstad
changed the title
workers-devprod
requested review from
a team and
dario-piotrowicz
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jamesopstad
force-pushed
the
james/support-new-module-registry
branch
2 times, most recently
from
b5202a2 to
fd3edb4
Compare
dario-piotrowicz
approved these changes
Apr 24, 2026
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
Member
There was a problem hiding this comment.
Looks good to me, with some few minor comments/suggestions 🙂
workers-devprod
approved these changes
Apr 24, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
jamesopstad
force-pushed
the
james/support-new-module-registry
branch
from
fd3edb4 to
64db9aa
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
Changeset ReviewFiles Reviewed
Review Results✅ All changesets look good Detailsshaky-parks-buy.md (miniflare - minor)
twelve-eggs-fetch.md (@cloudflare/vite-plugin - minor)
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
new_module_registrycompatibility flag is set, requests sent tounsafeModuleFallbackService()use a different protocol. This adds support in Miniflare and the Vite plugin.Updating vitest-pool-workers is considerably more complex so that will follow in a separate PR.
A picture of a cute animal (not mandatory, but encouraged)