Skip to content

Support stream (but keep pipeline backwards compatible) binding for Pipelines#13716

Merged
petebacondarwin merged 1 commit into
mainfrom
oli/pipelines_stream
May 6, 2026
Merged

Support stream (but keep pipeline backwards compatible) binding for Pipelines#13716
petebacondarwin merged 1 commit into
mainfrom
oli/pipelines_stream

Conversation

@oliy

@oliy oliy commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

PIPE-374

Fixes the mismatch between original Pipeline bindings and v1 Pipeline entities. Specifically that we are binding to a Stream now, which then feeds the Pipeline that delivers traffic to a Sink. We preserve the original bindings to avoid breaking existing pipelines, but issue a warning of the deprecated usage.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: PIPE-633

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@oliy oliy requested a review from workers-devprod as a code owner April 28, 2026 22:41
@changeset-bot

changeset-bot Bot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 40e5491

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 28, 2026
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team April 28, 2026 22:42
@workers-devprod

workers-devprod commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/plugins/pipelines/index.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/config/environment.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/config/validation.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/map-worker-metadata-bindings.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/types.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/worker.ts: [@cloudflare/wrangler]
  • packages/workers-utils/tests/config/validation/normalize-and-validate-config.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/e2e/remote-binding/miniflare-remote-resources.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/api/startDevWorker/LocalRuntimeController.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/create-worker-upload-form/bindings.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/durable-objects.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/get-remote-config-diff.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/dev/remote-bindings.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/init.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/type-generation.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/api/startDevWorker/utils.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/dev/miniflare/index.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/preview/api.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/preview/shared.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/type-generation/index.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/type-generation/pipeline-schema.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/utils/print-bindings.ts: [@cloudflare/wrangler]

devin-ai-integration[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@oliy Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new

pkg-pr-new Bot commented Apr 28, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13716

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13716

miniflare

npm i https://pkg.pr.new/miniflare@13716

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13716

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13716

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13716

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13716

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13716

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13716

wrangler

npm i https://pkg.pr.new/wrangler@13716

commit: 40e5491

@oliy oliy force-pushed the oli/pipelines_stream branch from 8459647 to d87e070 Compare April 29, 2026 13:48
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Changeset Review

✅ All changesets look good

devin-ai-integration[bot]

This comment was marked as resolved.

@oliy oliy force-pushed the oli/pipelines_stream branch 2 times, most recently from 928e085 to bad292e Compare April 30, 2026 06:40
devin-ai-integration[bot]

This comment was marked as resolved.

@oliy oliy force-pushed the oli/pipelines_stream branch from bad292e to fd20fdf Compare April 30, 2026 07:04
devin-ai-integration[bot]

This comment was marked as resolved.

@oliy oliy force-pushed the oli/pipelines_stream branch from fd20fdf to faa0b81 Compare April 30, 2026 16:10
devin-ai-integration[bot]

This comment was marked as resolved.

@oliy oliy force-pushed the oli/pipelines_stream branch from faa0b81 to b57720e Compare April 30, 2026 19:02
devin-ai-integration[bot]

This comment was marked as resolved.

@oliy oliy force-pushed the oli/pipelines_stream branch from b57720e to 633d290 Compare May 4, 2026 14:24
@workers-devprod

workers-devprod commented May 4, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Comment thread packages/miniflare/src/plugins/pipelines/index.ts Outdated
Comment thread packages/workers-utils/src/map-worker-metadata-bindings.ts Outdated
Comment thread packages/workers-utils/src/types.ts
@oliy oliy force-pushed the oli/pipelines_stream branch 3 times, most recently from 8683bd1 to 79d9bce Compare May 5, 2026 20:38
@oliy

oliy commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

Tests failing, but I don't think it's related to our changes. Looks like a bad image update for a docker container used in tests.

@petebacondarwin petebacondarwin force-pushed the oli/pipelines_stream branch from 79d9bce to 40e5491 Compare May 6, 2026 08:18

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 6, 2026
@petebacondarwin petebacondarwin merged commit 543b20b into main May 6, 2026
65 of 66 checks passed
@petebacondarwin petebacondarwin deleted the oli/pipelines_stream branch May 6, 2026 09:22
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants