fix(miniflare): expose send_email in platform proxy#13723
Conversation
🦋 Changeset detectedLatest commit: 82700f0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
Suggested fix: ---
"miniflare": minor
---
Expose `send_email` bindings from `getPlatformProxy()`
Projects developing in Node can now access `send_email` bindings from the platform proxy. This supports the plain-object MessageBuilder API locally, so calls like `env.EMAIL.send({ from, to, subject, text })` no longer fail because the binding is missing. |
|
UnknownError: ProviderInitError |
|
@edmundhung Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
2ab37cc to
4b36bb3
Compare
4b36bb3 to
ec39d73
Compare
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes #13715
This was not originally supported because email bindings relied on the
EmailMessageclass fromcloudflare:emailmodule, which is not available in the Node environment. Now thatsend_emailsupports the plain-objectMessageBuilderinterface, I think we should be able to enable this through thegetPlatformProxy().The local email binding previously used Miniflare's loopback server to write preview files. That deadlocks when called through the Node proxy, so this switches those file writes to a workerd disk service instead.
A picture of a cute animal (not mandatory, but encouraged)