Skip to content

Feat: update minor changes and UserGroupChannel details#5349

Merged
seungyeoneeee merged 8 commits intocloudforet-io:feature-project-alert-managerfrom
seungyeoneeee:feature/alert-iam-a
Dec 30, 2024
Merged

Feat: update minor changes and UserGroupChannel details#5349
seungyeoneeee merged 8 commits intocloudforet-io:feature-project-alert-managerfrom
seungyeoneeee:feature/alert-iam-a

Conversation

@seungyeoneeee
Copy link
Contributor

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
@vercel
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 1:16am
hotfix2 ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 1:16am

@vercel
Copy link

vercel bot commented Dec 27, 2024

@seungyeoneeee is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 27, 2024

Deployment failed with the following error:

Preview deployments are disabled for this project.

Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Comment on lines 94 to 100
/* custom design-system component - p-json-schema-form */
:deep(.p-json-schema-form) {
.p-text-input {
width: 100%;
max-width: 30rem;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀: Have the custom parts been added to Notion?


/* Component */
const handleConfirm = () => {
const handleConfirm = async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
@seungyeoneeee seungyeoneeee merged commit f568df3 into cloudforet-io:feature-project-alert-manager Dec 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants