feat(web-storybook): create storybook setup & refactor for separation of concerns#5570
Merged
sulmoJ merged 8 commits intocloudforet-io:developfrom Jan 23, 2025
Merged
feat(web-storybook): create storybook setup & refactor for separation of concerns#5570sulmoJ merged 8 commits intocloudforet-io:developfrom
sulmoJ merged 8 commits intocloudforet-io:developfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
github-actions
bot
added
pass/signedoff
pending/review
WANZARGEN
requested changes
Jan 21, 2025
Member
WANZARGEN
left a comment
WANZARGEN
left a comment
There was a problem hiding this comment.
Wow. Thanks for your hard work!! Kudos!!
I left some suggestions, and let's discuss.
Member
There was a problem hiding this comment.
suggestion: What about to move it to mirinae-foundation package?
Member
There was a problem hiding this comment.
suggestion: I think it's far better to move it to the mirinae-foundation package
sulmoJ
force-pushed
the
develop
branch
2 times, most recently
from
cbe0c12 to
f82d953
Compare
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.3 to 4.5.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Wanjin Noh <wanjin@megazone.com>
refactor: restructure styles and update imports - Moved style files to a new package directory - Updated import paths for colors, screens, and fonts - Added mirinae-foundation as a dependency in package.json Signed-off-by: sulmo <sulmo@megazone.com> refactor(tailwind): simplify config by extending default settings - Replaced custom Tailwind configuration with an extended default config - Removed redundant theme, variants, and plugins definitions - Updated content paths for style processing Signed-off-by: sulmo <sulmo@megazone.com>
…ncerns Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: sulmo <sulmo@megazone.com>
…irinae-foundation Signed-off-by: sulmo <sulmo@megazone.com>
- Removed `@storybook/theming` dependency and replaced with custom theme creation. - Updated import paths and methods for setting Storybook configurations. - Adjusted package.json to reflect changes in dependencies. - Simplified path resolution in storybook-config-custom. Signed-off-by: sulmo <sulmo@megazone.com>
- Change the development server port from 6006 to 6007 in the script configuration. Signed-off-by: sulmo <sulmo@megazone.com>
github-actions
bot
removed
the
pending/review
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
I have created a Storybook for the console components.
To achieve this, I have separated the concerns within the repository into distinct packages:
postcss-config-custom
mirinae-foundation
storybook-config-custom
콘솔 컴포넌트를 위한 스토리북을 생성했습니다.
이를 위해 현재 레포의 패키지 관심사 분리를 진행하였습니다.
Things to Talk About (optional)