Skip to content

feat: update pairsForm & pairsInputGroup component#5606

Merged
seungyeoneeee merged 2 commits intocloudforet-io:feature-project-alert-managerfrom
seungyeoneeee:feature/pairs-form-md
Feb 4, 2025
Merged

feat: update pairsForm & pairsInputGroup component#5606
seungyeoneeee merged 2 commits intocloudforet-io:feature-project-alert-managerfrom
seungyeoneeee:feature/pairs-form-md

Conversation

@seungyeoneeee
Copy link
Contributor

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

  • Format messages when updating the 'Service' design because the request requires a longer text input width
  • common component PairsForm & PairsInputGroup are used in this page
  • All pages using that component will not be affected by this update, except when using the 'is-long-value' prop.
  • without is-longer-value
    image
  • with is-longer-value
    image

Things to Talk About (optional)

Signed-off-by: 이승연 <sylee1274@mz.co.kr>
@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:49am
dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:49am

@github-actions github-actions bot added pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. pass/signedoff labels Jan 23, 2025
@github-actions
Copy link
Contributor

🎉 @WANZARGEN and @kkdy21 have been randomly selected as the reviewers! Please review. 🙏

@github-actions github-actions bot requested review from WANZARGEN and kkdy21 January 23, 2025 07:31
@seungyeoneeee seungyeoneeee added self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. and removed pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Jan 23, 2025
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seungyeoneeee seungyeoneeee merged commit d27c8a0 into cloudforet-io:feature-project-alert-manager Feb 4, 2025
8 of 9 checks passed
@seungyeoneeee seungyeoneeee deleted the feature/pairs-form-md branch February 4, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants