Skip to content

build: update turbo to version 2.3.4 #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2025
Merged

build: update turbo to version 2.3.4 #5609

merged 1 commit into from
Feb 3, 2025

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Jan 31, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Turbo 2.3.4 Breaking changes
Configuration
  • Ignore turbo field in package.json (PR)
  • Turborepo’s default disk cache location moved to .turbo/cache from node_modules/.cache (PR)
  • pipeline key in turbo.json renamed to tasks (PR)
  • File globs for directories in inputs/outputs include the directory's contents (e.g. dist anddist/ equal dist/**) (PR)
  • outputMode key renamed to outputLogs for clarity and to match the --output-logs flag (PR)
  • This change will be reflected in Run Summaries in resolvedTaskConfig
  • Error on environment variable syntax in dependsOn and globalDependencies (deprecated since 1.4) (PR)
  • globalDotEnv and dotEnv removed in favor of including .env files in inputs (PR)
  • --ignore removed in favor of --filter and graph correctness changes below (PR)
Correctness
  • Strict Mode for environment variables is now the default, moving from Loose Mode (PR)
  • Workspace root directory is now an implicit dependency of all packages (PR)
  • Removed --scope flag (deprecated since 1.2) (PR)
  • Packages must have a name in package.json (PR)
  • packageManager field in root package.json is now required (PR)
  • engines field in root package.json is now used in hashing (PR)
  • --filter no longer infers namespaces for package names (PR)
  • --filter now errors when no package names or directories are matched (PR)
  • --only restricts task dependencies instead of only package dependencies (PR)

Things to Talk About (optional)

@sulmoJ
build: update turbo to version 2.3.4
4acfa3d 
- Updated the turbo package from version 1.13.4 to 2.3.4.
- Modified configuration in turbo.json, changing "pipeline" to "tasks".
- Added a persistent flag to the dev task in turbo.json.

Signed-off-by: sulmo <[email protected]>
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 8:05am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 8:05am

@github-actions github-actions bot added pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. pass/signedoff labels Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

🎉 @piggggggggy and @seungyeoneeee have been randomly selected as the reviewers! Please review. 🙏

piggggggggy
piggggggggy approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@piggggggggy piggggggggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@WANZARGEN WANZARGEN added approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. and removed pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Feb 3, 2025
seungyeoneeee
seungyeoneeee approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@seungyeoneeee seungyeoneeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@sulmoJ sulmoJ merged commit b9b7959 into cloudforet-io:develop Feb 3, 2025
7 of 9 checks passed
@sulmoJ sulmoJ deleted the turbo-repo-update branch February 3, 2025 05:42
@github-actions github-actions bot removed the approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piggggggggy piggggggggy piggggggggy approved these changes

@seungyeoneeee seungyeoneeee seungyeoneeee approved these changes

Assignees

@sulmoJ sulmoJ

Labels
pass/signedoff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sulmoJ @piggggggggy @seungyeoneeee @WANZARGEN