Skip to content

Revert "chore: create workflows merge from master to develop and check commits (#5611)" #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Feb 4, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA

Things to Talk About (optional)

@sulmoJ sulmoJ added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Feb 4, 2025
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 7:15am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 7:15am
dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 7:15am

Copy link
Contributor

github-actions bot commented Feb 4, 2025

🎉 @skdud4659 and @seungyeoneeee have been randomly selected as the reviewers! Please review. 🙏

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ @sulmoJ the signed-off-by was not found in the following 2 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@sulmoJ sulmoJ merged commit b876ebb into cloudforet-io:master Feb 4, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant