feat: add alert fields and fix copy value bug #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NaYeong,Kim <[email protected]>
Signed-off-by: NaYeong,Kim <[email protected]>
Signed-off-by: NaYeong,Kim <[email protected]>
skdud4659
added
the
self_approved/review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
|
✅ There are no commits in this PR that require review. |
There was a problem hiding this comment.
Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- packages/language-pack/console-translation-2.8.babel: Language not supported
- packages/language-pack/en.json: Language not supported
- packages/language-pack/ja.json: Language not supported
- packages/language-pack/ko.json: Language not supported
| periodMenuItems: computed<AlertPeriodItemType[]>(() => [ | ||
| { | ||
| name: ALERT_PERIOD_DROPDOWN_MENU.LAST_1_MONTH, | ||
| relativePeriod: { unit: 'month', value: 1 }, |
There was a problem hiding this comment.
The 'relativePeriod' object includes an extra 'unit' property which is not defined in the AlertRelativePeriod type. Consider removing the 'unit' property from all relativePeriod definitions to ensure consistency with the expected type.
Suggested change
| relativePeriod: { unit: 'month', value: 1 }, | |
| relativePeriod: { value: 1 }, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Signed-off-by: NaYeong,Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)