feat(project-dashboard): create project-dashboard actions #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date) Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
…n helper Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
piggggggggy
added
the
self_approved/review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
There was a problem hiding this comment.
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
apps/web/src/services/project/v2/pages/ProjectMainPage.vue:131
- Review the conditional rendering of : changing the check from using 'projectId' to 'props.projectGroupOrProjectId' might lead to the component not rendering when only 'projectId' is defined. Please verify this change is intentional.
<project-detail-tab v-if="mounted && props.projectGroupOrProjectId"
apps/web/src/services/dashboards/components/dashboard-detail/DashboardDetailHeader.vue:26
- Changing 'folderItems' from an optional prop to a required one could cause runtime errors if the parent component does not provide it. Consider providing a default value or keeping it optional if needed.
folderItems: Array<FolderModel>;
Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/web/src/services/dashboard-shared/core/actions/use-dashboard-clone-action.ts:73
- In the clone action, the resource_group property is no longer set for non-private dashboards after removing the context-based conditions. If resource_group is required for dashboard creation, please add explicit logic to assign the appropriate resource_group based on the dashboard context.
const _sharedDashboard: DashboardCreateParams = {
0c1a68a
into
feature-integration-project-detail
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)