Feature refactoring

[ImMin5]

Category

• New feature
• Bug fix
• Improvement
• Refactor
• etc

Description

Known issue

[Copilot]

Pull Request Overview

This pull request refactors several gRPC interface implementations by replacing the locator-based service calls with direct instantiation of service classes and makes adjustments to error messages and configuration settings. Key changes include:

• Refactoring gRPC interface methods in cost_analysis services (data_source_rule, data_source, cost_query_set, cost, budget_usage) to use direct service instantiation.
• Removing deprecated info modules and updating error messages in budget error handling.
• Updating connector implementations, Helm chart configurations, and CI workflow settings.

Reviewed Changes

Copilot reviewed 102 out of 102 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/spaceone/cost_analysis/interface/grpc/*.py	Replaces locator-based service calls with direct service instantiation for improved clarity.
src/spaceone/cost_analysis/info/*.py	Removes multiple info modules as part of the refactoring cleanup.
src/spaceone/cost_analysis/error/budget.py	Updates error messages to use singular "notification" and adjusts parameter placeholders.
src/spaceone/cost_analysis/connector/*.py	Updates connector instantiation (e.g., SpaceConnector usage) and adds a new import.
src/spaceone/cost_analysis/conf/global_conf.py & deploy/helm/*	Introduces new budget settings and scheduler entries with version updates.
.github/workflows/dispatch_daily_build.yaml	Updates CI runner to use ubuntu-latest.

Comments suppressed due to low confidence (3)

src/spaceone/cost_analysis/error/budget.py:33

• Verify that changing 'notifications' to 'notification' ensures consistency with the rest of the codebase and documentation.

_message = "Unit is required for notification (key = notification, value = {value})"

src/spaceone/cost_analysis/error/budget.py:37

• Please confirm that the singular usage of 'notification' in the error message aligns with the expected input keys throughout the system.

_message = "Notification type is required for notification (key = notification, value = {value})"

src/spaceone/cost_analysis/error/budget.py:55

• Ensure that the updated error message placeholders (start, end) are supported by the calling code and tests, as this change might impact downstream validation.

_message = "Budget already exist. (start = {start} end = {end}, target = {target}, workspace_id = {workspace_id})"

[github-actions]

⚠️ @ImMin5 the signed-off-by was not found in the following 10 commits:

• 07ea57c: Merge pull request Modify field name notifications -> notification  #334 from ImMin5/master
• 04e7288: Merge pull request Add budget_manager_id field for Budget #335 from ImMin5/master
• 0bb93de: Merge pull request Implement budget utilization rate update scheduler and related tasks #336 from ImMin5/master
• a939a16: Merge pull request Add convert model decorator at stat api #337 from ImMin5/master
• c57ea93: Merge pull request Add budget year field and modify budget update scheduler #338 from ImMin5/master
• 1798d79: Merge pull request Modify budget and budget usage index order #339 from ImMin5/master
• 032456a: refactor: migrate cost report services to UnifiedCost model
• e78e742: Merge pull request Enhance budget notification logic #341 from ImMin5/master
• e69ef09: Merge pull request Modify cost report run scheduler class name #342 from ImMin5/master
• 89502bf: Merge pull request Update workflow to use Ubuntu 22.04 #343 from ImMin5/master

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

[github-actions]

⚠️ @ImMin5 the signed-off-by was not found in the following 10 commits:

• 07ea57c: Merge pull request Modify field name notifications -> notification  #334 from ImMin5/master
• 04e7288: Merge pull request Add budget_manager_id field for Budget #335 from ImMin5/master
• 0bb93de: Merge pull request Implement budget utilization rate update scheduler and related tasks #336 from ImMin5/master
• a939a16: Merge pull request Add convert model decorator at stat api #337 from ImMin5/master
• c57ea93: Merge pull request Add budget year field and modify budget update scheduler #338 from ImMin5/master
• 1798d79: Merge pull request Modify budget and budget usage index order #339 from ImMin5/master
• 032456a: refactor: migrate cost report services to UnifiedCost model
• e78e742: Merge pull request Enhance budget notification logic #341 from ImMin5/master
• e69ef09: Merge pull request Modify cost report run scheduler class name #342 from ImMin5/master
• 89502bf: Merge pull request Update workflow to use Ubuntu 22.04 #343 from ImMin5/master

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'