Skip to content

Push Merged Refactoring Codes to Master #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Push Merged Refactoring Codes to Master #358

wants to merge 13 commits into from

Conversation

jinyoungmoonDEV
Copy link
Contributor

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Merged Refactoring Codes --(push)--> Master

@jinyoungmoonDEV
refactor: refactor service, manager and model
bef1d28
@jinyoungmoonDEV
fix: fix schedule logic from DataSource
2fbcbf7
@jinyoungmoonDEV
refactor: refactoring cost_report
247fb1d
@jinyoungmoonDEV
refactor: refactoring manager file
2b8352e
@jinyoungmoonDEV
refactor: refactoring manager files
11da68c
@jinyoungmoonDEV
refactor: refactoring interface & manager files
59c2b90
@jinyoungmoonDEV
fix: fix update master commit from 235f5fe to 505e89d
b4c4f3e
@jinyoungmoonDEV
fix: fix update master commit from 6a01a04 to be1ef56
71a90cb
@jinyoungmoonDEV
fix: fix update master commit from 266718b to f34e222
caa9179
@jinyoungmoonDEV
fix: fix services params data handling
e931e32
@jinyoungmoonDEV
fix: remove locator logic
007da87
@jinyoungmoonDEV
fix: fix import method from managers
184fa35
@jinyoungmoonDEV
Merge branch 'master' into feature-refactoring
6d79ef6 
# Conflicts:
#	src/spaceone/cost_analysis/connector/currency_connector.py
#	src/spaceone/cost_analysis/interface/grpc/data_source.py
#	src/spaceone/cost_analysis/manager/unified_cost_manager.py
#	src/spaceone/cost_analysis/model/data_source_model.py
#	src/spaceone/cost_analysis/model/job_task/database.py
#	src/spaceone/cost_analysis/service/cost_report_data_service.py
#	src/spaceone/cost_analysis/service/cost_service.py
#	src/spaceone/cost_analysis/service/data_source_service.py
#	src/spaceone/cost_analysis/service/job_service.py
#	src/spaceone/cost_analysis/service/unified_cost_service.py
@jinyoungmoonDEV jinyoungmoonDEV requested a review from ImMin5 April 29, 2025 01:58
@github-actions GitHub Actions
Copy link

⚠️ @jinyoungmoonDEV the signed-off-by was not found in the following 13 commits:

  • bef1d28: refactor: refactor service, manager and model
  • 2fbcbf7: fix: fix schedule logic from DataSource
  • 247fb1d: refactor: refactoring cost_report
  • 2b8352e: refactor: refactoring manager file
  • 11da68c: refactor: refactoring manager files
  • 59c2b90: refactor: refactoring interface & manager files
  • b4c4f3e: fix: fix update master commit from 235f5fe to 505e89d
  • 71a90cb: fix: fix update master commit from 6a01a04 to be1ef56
  • caa9179: fix: fix update master commit from 266718b to f34e222
  • e931e32: fix: fix services params data handling
  • 007da87: fix: remove locator logic
  • 184fa35: fix: fix import method from managers
  • 6d79ef6: Merge branch 'master' into feature-refactoring

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@github-actions GitHub Actions
Copy link

⚠️ @jinyoungmoonDEV the signed-off-by was not found in the following 13 commits:

  • bef1d28: refactor: refactor service, manager and model
  • 2fbcbf7: fix: fix schedule logic from DataSource
  • 247fb1d: refactor: refactoring cost_report
  • 2b8352e: refactor: refactoring manager file
  • 11da68c: refactor: refactoring manager files
  • 59c2b90: refactor: refactoring interface & manager files
  • b4c4f3e: fix: fix update master commit from 235f5fe to 505e89d
  • 71a90cb: fix: fix update master commit from 6a01a04 to be1ef56
  • caa9179: fix: fix update master commit from 266718b to f34e222
  • e931e32: fix: fix services params data handling
  • 007da87: fix: remove locator logic
  • 184fa35: fix: fix import method from managers
  • 6d79ef6: Merge branch 'master' into feature-refactoring

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImMin5 ImMin5 Awaiting requested review from ImMin5

Assignees
No one assigned
Labels
fail/signedoff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jinyoungmoonDEV