Skip to content

fix: correct string formatting in Content-Disposition header for file… #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kang2453 merged 1 commit into from
Dec 31, 2024
Merged

fix: correct string formatting in Content-Disposition header for file… #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/spaceone/file_manager/interface/rest/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ async def download_public_file(self, request: Request, file_id: str):
return StreamingResponse(
content=file_stream,
media_type="application/octet-stream",
headers={"Content-Disposition": f"attachment; filename={file_vo["name"]}"}
headers={"Content-Disposition": f"attachment; filename={file_vo['name']}"}
)

@router.post("/domain/{domain_id}/upload")
Expand Down Expand Up @@ -129,7 +129,7 @@ async def download_domain_file(self, domain_id:str, file_id:str, request: Reques
return StreamingResponse(
content=file_stream,
media_type="binary/octet-stream",
headers={"Content-Disposition": f"attachment; filename={file_vo["name"]}"}
headers={"Content-Disposition": f"attachment; filename={file_vo['name']}"}
)
except Exception as e:
raise ERROR_FILE_DOWNLOAD_FAILED(file_id=file_id)
Expand Down Expand Up @@ -186,7 +186,7 @@ async def download_workspace_file(self, domain_id:str, workspace_id:str, file_id
return StreamingResponse(
content=file_stream,
media_type="binary/octet-stream",
headers={"Content-Disposition": f"attachment; filename={file_vo["name"]}"}
headers={"Content-Disposition": f"attachment; filename={file_vo['name']}"}
)

def get_download_url(self, response: dict ) -> str:
Expand Down
Loading