Skip to content

Added 2 new schemas needed for aws account sync function #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Sooyoung98
Copy link
Member

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Known issue

Copy link

github-actions bot commented Apr 8, 2024

⚠️ @Sooyoung98 the signed-off-by was not found in the following 1 commits:

  • 0fb234b: feat: added 2 new schemas needed for aws account sync function

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

github-actions bot commented Apr 8, 2024

⚠️ @Sooyoung98 the signed-off-by was not found in the following 2 commits:

  • 0fb234b: feat: added 2 new schemas needed for aws account sync function
  • 4da4b4b: feat: added control tower schema to trusted account schema

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@Sooyoung98 Sooyoung98 merged commit e30ccf9 into cloudforet-io:master Apr 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant