Skip to content

feat: remove set_query_page_limit decorator at list of sa #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 26, 2025
Merged

feat: remove set_query_page_limit decorator at list of sa #434

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ac1110e
feat: remove set_query_page_limit decorator at list of sa
ImMin5 Feb 26, 2025
50afcef
fix: Fix error when updating Service Account name
lhhyung Feb 11, 2025
f0b0526
feat: Add expiring app check scheduler
lhhyung Feb 11, 2025
082e2bb
fix: Update email template for app expiration check
lhhyung Feb 11, 2025
7117678
fix: Fix typo
lhhyung Feb 11, 2025
7a25ebc
fix: Add email_verified filter to user query for app expiration check…
lhhyung Feb 12, 2025
99955af
feat: Add app expiration email
lhhyung Feb 12, 2025
246cc4b
feat: Add app expiration email template (ja)
lhhyung Feb 12, 2025
4779a0f
build: Add expiring_app_check_scheduler to helm chart
lhhyung Feb 17, 2025
0478ed7
feat: resolve merge conflict
ImMin5 Feb 26, 2025
bbe26fd
Merge branch 'master' into master
ImMin5 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/spaceone/identity/service/service_account_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ def update(
)

if (
service_account_vo.secret_id and params.project_id
service_account_vo.secret_id
and params.project_id
and service_account_vo.project_id != params.project_id
):
secret_manager = SecretManager()
Expand Down Expand Up @@ -418,7 +419,7 @@ def get(
]
)
@append_keyword_filter(["service_account_id", "name"])
# @set_query_page_limit(2000)
@set_query_page_limit(2000)
@convert_model
def list(
self, params: ServiceAccountSearchQueryRequest
Expand Down
Loading