Add Advisor Cost impacted resource type count metric

[lhhyung]

Category

• New feature
• Bug fix
• Improvement
• Refactor
• etc

Description

Add Advisor Cost impacted resource type count metric

Known issue

[github-actions]

⚠️ @lhhyung the signed-off-by was not found in the following 2 commits:

• 0b59993: add: Add Advisor Cost impacted resource type count metric
• bc547cc: Merge remote-tracking branch 'origin/master'

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

src/plugin/metrics/Advisor/cost/recommendation_impacted_resource_type_count.yaml:2

• The 'metric_id' does not reflect the functionality of this new metric. Consider renaming it to something like 'metric-azure-advisor-impacted-resource-type-count' for clarity.

metric_id: metric-azure-advisor-cost-saving

src/plugin/metrics/Advisor/cost/recommendation_count.yaml:34

• The namespace ID change from 'ns-azure-advisor-recommendations' to 'ns-azure-advisor-cost' may affect metric grouping. Verify if this change is intentional to ensure consistency across related metrics.

namespace_id: ns-azure-advisor-cost

src/plugin/metrics/Advisor/cost/recommendation_cost_saving.yaml:3

• [nitpick] The change from 'Cost Savings Recommendation' to 'Cost Saving Recommendation' may lead to naming inconsistencies. Consider aligning the name with established documentation or reverting if the plural form is preferred.

name: Cost Saving Recommendation

src/plugin/metrics/Advisor/cost/recommendation_cost_saving.yaml:35

• The namespace ID update to 'ns-azure-advisor-cost' should be reviewed for consistency with other metrics. Verify that this adjustment aligns with the intended grouping of cost-related Advisor metrics.

namespace_id: ns-azure-advisor-cost