Modify advisor metric data

src/plugin/manager/advisor/recommendation_reliability_manager.py

@@ -28,14 +28,6 @@ def create_cloud_service(self, options: dict, secret_data: dict, schema: str):
         recommendation_filter = "Category eq 'HighAvailability'"
         recommendations = advisor_conn.list_recommendations(recommendation_filter=recommendation_filter)
 
-        # metadata = advisor_conn.list_metadata()
-        # print("metadata start")
-        # for meta in metadata:
-        #     meta_info = self.convert_nested_dictionary(meta)
-        #     print(meta_info)
-        #     print("===========================")
-        #
-        # print("metadata end")
         for recommendation in recommendations:
             try:
                 recommendation_info = self.convert_nested_dictionary(recommendation)
@@ -45,8 +37,7 @@ def create_cloud_service(self, options: dict, secret_data: dict, schema: str):
                     "subscription_name": subscription_info.get("display_name"),
                 })
 
-                recommendation_info["impacted_value_display"] = recommendation_info.get("impacted_value",
-                                                                                        "subscription_name")
+                recommendation_info["impacted_value_display"] = recommendation_info.get("impacted_value", )
                 short_description = recommendation_info.get("short_description")
                 extended_properties = recommendation_info.get("extended_properties", {}) or {}
 
@@ -108,4 +99,8 @@ def _get_name_from_short_description(short_description: dict) -> str:
 
     @staticmethod
     def _get_region_from_extended_properties(extended_properties: dict) -> Union[str, None]:
-        return extended_properties.get("region", None)
+        if region := extended_properties.get("region"):
+            return region
+        elif region := extended_properties.get("Location"):
+            return region
+        return region

src/plugin/metadata/advisor/cost.yaml

@@ -20,7 +20,6 @@ table:
     desc: false
   fields:
     - Impact: data.impact
-    - Description: data.short_description.problem
     - Category: data.category
     - Potential yearly savings based on retail pricing: data.potential_yearly_savings_based_on_retail_pricing_display
     - Currency: data.extended_properties.savingsCurrency

src/plugin/metadata/advisor/security.yaml

@@ -18,7 +18,7 @@ table:
     - Impact: data.impact
     - Description: data.short_description.problem
     - Category: data.category
-    - Impacted resource name: data.impacted_value_display
+    - Impacted resource name: data.extended_properties.assessmentKey
     - Impacted resource: data.impacted_field
     - Last updated at: data.last_updated
 
@@ -30,8 +30,15 @@ tabs.0:
     - Tenant ID: data.tenant_id
     - Subscription Name: data.subscription_name
     - Subscription ID: data.subscription_id
+    - Name: name
     - Recommendation name: data.name
     - Impact: data.impact
     - Category: data.category
-    - End time: data.impact_mitigation_time
-    - Last update time: data.last_update_time
+    - Last update time: data.last_updated
+
+  tabs.1:
+    name: Extended Properties
+    type: item
+    fields:
+      - Score: data.extended_properties.score
+      - AssessmentKey: data.extended_properties.assessmentKey

src/plugin/metrics/ServiceHealth/health_history/health_history_impacted_service_count.yaml

@@ -18,8 +18,6 @@ query_options:
       reference:
         resource_type: inventory.Region
         reference_key: region_code
-    - key: data.impacted_services_display
-      name: Impacted Service
     - key: data.tenant_id
       name: Tenant ID
     - key: data.subscription_name