Skip to content

check for prefix in service.go #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dudejas
Copy link

@dudejas dudejas commented May 5, 2025

No description provided.

Copy link

linux-foundation-easycla bot commented May 5, 2025

CLA Not Signed

@fmoehler fmoehler marked this pull request as draft May 6, 2025 12:42
@aramprice
Copy link
Member

Instead of adding GetPrimaryIPv6 and SearchIPv6Routes, would it be possible to have generic IP version agnostic public methods (ex: SearchRoutes and GetPrimaryIP) which call into IP version specific non-exported functions?

ex:
GetPrimaryIP internally calls either getPrimaryIPv4 or getPrimaryIPv6
SearchRoutes internally calls either searchRoutesIPv4 or searchRoutesIPv6

Perhaps we do need to expose both IPv6 and IPv4 variants for get-primary-ip and search-routes, if that is the case then it would be good if the variants were named consistently:

ex:
GetPrimaryIPv4 , GetPrimaryIPv6
SearchRoutesIPv4, SearchRoutesIPv6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants