Pin http-cookie < 1.1 for delete-vms task on Ruby 3.4#164
Merged
KauzClay merged 1 commit intowindows-2019from Apr 8, 2026
Merged
Pin http-cookie < 1.1 for delete-vms task on Ruby 3.4#164KauzClay merged 1 commit intowindows-2019from
KauzClay merged 1 commit intowindows-2019from
Conversation
selzoc
previously approved these changes
Apr 8, 2026
http-cookie 1.1+ requires cookie_jar before HTTP::Cookie defines MAX_COOKIES_TOTAL, which breaks when Azure/ms_rest loads Faraday’s cookie jar. 1.0.x autoloads CookieJar after the class is defined. Fixes delete-orphan-vms NameError after successful Packer runs. hopefully we can remove this once fixed upstream: sparklemotion/http-cookie#62 ai-assisted=yes [TNZ-88993] [Europa] Bosh Ecosystem KTLO Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
KauzClay
force-pushed
the
fix-create-azure
branch
from
9734475 to
a015fe0
Compare
selzoc
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http-cookie 1.1+ requires cookie_jar before HTTP::Cookie defines MAX_COOKIES_TOTAL, which breaks when Azure/ms_rest loads Faraday’s cookie jar. 1.0.x autoloads CookieJar after the class is defined.
Fixes delete-orphan-vms NameError after successful Packer runs.
hopefully we can remove this once fixed upstream: sparklemotion/http-cookie#62
https://ci.bosh-ecosystem.cf-app.com/teams/main/pipelines/stemcells-windows-2019/jobs/create-azure/builds/215