Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cc-uploader process did not have a draining mechanism. When the process was stopped, any ongoing droplet uploads were aborted immediately, leading to potential failures and incomplete uploads.
This PR introduces a graceful shutdown mechanism to allow ongoing uploads to complete before termination. The key enhancements include:
SIGINT
,SIGTERM
) and responds by allowing uploads to finish before exiting.WaitGroup
(uploadWaitGroup
) is introduced to track ongoing uploads.trackedPoller
) ensures uploads are properly accounted for by incrementing/decrementing theWaitGroup
.cc-uploader
will:forceShutdown()
) ensures the process does not hang indefinitely.Code Changes
signalChan
to capture termination signals.uploadWaitGroup
ensurescc-uploader
waits for all uploads to finish before stopping.Poller
to track polling completion, ensuring uploads are properly accounted for.