-
Notifications
You must be signed in to change notification settings - Fork 368
Compare fog vs storage-cli benchmarks #4738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bcd5b28 to
6740b34
Compare
5ecaeda to
18c9e07
Compare
18c9e07 to
c2b5e4b
Compare
141dc7c to
853ebfa
Compare
853ebfa to
af82bd6
Compare
| task perform_blobstore_benchmark: :environment do | ||
| BackgroundJobEnvironment.new(RakeConfig.config).setup_environment do | ||
| RakeConfig.context = :blobstore_benchmarks | ||
| BoshErrandEnvironment.new(RakeConfig.config).setup_environment do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the rake task still executable without bosh errand? E.g. when developing locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you set blobstore_type and blobstore_provider in a ccng.yml and export it as CLOUD_CONTROLLER_NG_CONFIG and export the DB_CONNECTION_STRING, yes
A short explanation of the proposed change:
This change introduces a dedicated configuration context and schema for running fog and storage-cli blobstore benchmarks as BOSH errands.
It adds a new BlobstoreBenchmarksSchema that defines exactly which configuration keys are required to run the benchmark (logging, database, blobstore sections, and storage-cli config paths).
It sets the blobstore_benchmarks config context to :blobstore_benchmarks.
An explanation of the use cases your change solves
Accurate performance comparison, validation of experimental storage-cli support and regression detection.
Enables running blobstore benchmarks as a standalone BOSH errand.
Links to any other associated PRs
Add blobstore benchmark job for performance testing capi-release#601
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests