Implement the /v3/apps/{guid}/manifest endpoint #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uzabanov
force-pushed
the
issues/4258-implement-app-manifest-endpoint
branch
from
bc0d47b to
670d41e
Compare
Implementing the app manifest endpoint includes calliing the `CollectState` method which gives as full information as possible for the `ManifestApplication` type (Routes,Processes,Services,AppRecord,Droplet). The following changes are made: * Calling `GetDroplet` in `Collect state` to encapsulate the build record in the `AppState` * Implementing `ToManifest` method to `AppState` type to map records to the `Manifest` types * It turned out that the routes repository returns only the `GUID` not the full `DomainRecord`, so the domainrepo is injected in the route repository and gets the full domain record for a route. Also unneccesary look ups for the domain are removed from the route and domain handler * Smoke test from the `cf create-app-manifest` command which calls the implemented manifest endpoint Closes #4258
uzabanov
force-pushed
the
issues/4258-implement-app-manifest-endpoint
branch
from
670d41e to
5224a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#4258
What is this change about?
Implementing the app manifest endpoint includes calliing the
CollectStatemethod which gives as fullinformation as possible for the
ManifestApplicationtype(Routes,Processes,Services,AppRecord,Droplet).