Implement custom http request timeout executor #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanBorislavovDimitrov
force-pushed
the
custom-http-executor
branch
2 times, most recently
from
2e777bc to
a86eea9
Compare
ikasarov
reviewed
Apr 10, 2025
| } | ||
|
|
||
| public <T> T executeWithTimeout(HttpUriRequest request, long timeoutInMillis, Function<HttpResponse, T> responseHandler) { | ||
| TimerTask task = buildAbortRequestTimerTask(request); |
There was a problem hiding this comment.
rename task to something a bit more descriptive - e.g. abortRequestTask
|
|
||
| public <T> T executeWithTimeout(HttpUriRequest request, long timeoutInMillis, Function<HttpResponse, T> responseHandler) { | ||
| TimerTask task = buildAbortRequestTimerTask(request); | ||
| Timer timer = new Timer(true); |
ikasarov
approved these changes
Apr 11, 2025
vkalapov
approved these changes
Apr 11, 2025
vkalapov
approved these changes
Apr 11, 2025
LMCROSSITXSADEPLOY-1549
IvanBorislavovDimitrov
force-pushed
the
custom-http-executor
branch
from
58f62cf to
0fce5d6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.