Feature/dns proxy healthcheck tnz 66259 #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Inbox
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
abg
reviewed
Dec 2, 2025
Member
abg
left a comment
abg
left a comment
There was a problem hiding this comment.
Left a few more comments on the "pingdb" integration test.
kimago
force-pushed
the
feature/dns-proxy-healthcheck-TNZ-66259
branch
5 times, most recently
from
aa39c24 to
8631d4e
Compare
Member
Author
|
Re-submitting this for review. The last 2 commits are trivial (bumps to dependencies & "Eventually()" intervals); the prior 3 are:
|
- Validate proxy dns healthcheck script influences bosh dns behavior and that connections to the proxy via the bosh-dns proxy link address continue to work. - Cycle that test across all proxies (presumes 2 proxy nodes) to ensure we observe DNS route new connections away from an unhealthy proxy. [TNZ-66259](https://vmw-jira.broadcom.net/browse/TNZ-66259) Authored-by: Kim Bassett <[email protected]>
Runs a new "pingdb" command provided by the switchboard module to validate the proxy is routing connections to a valid MySQL backend. [TNZ-66259](https://vmw-jira.broadcom.net/browse/TNZ-66259) Authored-by: Kim Bassett <[email protected]>
pingdb is expected to be colocated with the proxy and connects over localhost to the local proxy instance on the proxy port and establishes a MySQL connection without credentials. If a MySQL server response is detected, the proxy is routing connections to a valid backend and pingdb succeeds. Otherwise pingdb fails on any other error. Notes: - Move the switchboard proxy main entrypoint to ./cmd/proxy/ - Adds new ./cmd/pingdb to aid in DNS healthchecks for the proxy - Adds new internal/testing/docker package to assist in integration tests for the new pingdb command [TNZ-66259](https://vmw-jira.broadcom.net/browse/TNZ-66259) Authored-by: Kim Bassett <[email protected]>
abg
force-pushed
the
feature/dns-proxy-healthcheck-TNZ-66259
branch
from
2db4170 to
e1173f3
Compare
Member
|
Rebased on main and cleaned up some of the commit history after an internal discussion with @kimago Once unit tests pass on the rebased changes, I will merge. |
github-project-automation
bot
moved this from Waiting for Changes | Open for Contribution
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.
Feature or Bug Description
What does this PR change?
Discussed in Jira story notes: https://vmw-jira.broadcom.net/browse/TNZ-66259?focusedId=20850661&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-20850661
Motivation
Tell us about the problem you are facing, with context, that this PR solves.
Related Issue
If this PR was first opened as an issue, please provide the link to that issue here.